[feature](tls) Add TLS-aware internal HTTP client provider - #67223
Open
Yukang-Lian wants to merge 3 commits into
Open
[feature](tls) Add TLS-aware internal HTTP client provider#67223Yukang-Lian wants to merge 3 commits into
Yukang-Lian wants to merge 3 commits into
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#65212 Problem Summary: Internal FE HTTP callers are coupled to the OSS enable_https transport and cannot obtain URL normalization or TLS-aware clients from an extension. Add a public ServiceLoader provider with an OSS fallback, preserve the existing FE HTTPS trust behavior, and route the centralized FE URL, connection, Apache HTTP, and RestTemplate call paths through it. The rewrite keeps BE manager calls on plain HTTP, preserves raw encoded URI components, keeps SSRF cleanup unchanged, and does not alter group-commit forwarding fallback. ### Release note Add an extension point for TLS-aware internal FE HTTP clients. ### Check List (For Author) - Test: Unit Test: ./run-fe-ut.sh --run org.apache.doris.httpv2.client.OssInternalHttpClientProviderTest,org.apache.doris.common.util.HttpURLUtilTest,org.apache.doris.httpv2.rest.manager.HttpUtilsTest (16 passed) - Behavior changed: Yes. Internal FE HTTP clients can be supplied by a ServiceLoader provider; OSS enable_https behavior is centralized without changing BE HTTP routing. - Does this need documentation: No
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Make FE-to-FE and FE-to-BE requests explicitly select the internal TLS client and normalize their endpoint. Under HTTP TLS, group commit still selects the group-commit backend directly while skipping the extra BE-to-BE forward hop.
Yukang-Lian
requested review from
924060929,
deardeng,
englefly,
gavinchou,
liaoxin01,
morrySnow,
mymeiyi and
starocean999
as code owners
August 28, 2026 04:35
Yukang-Lian
changed the title
morrySnow
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #65212
Problem Summary: Internal node-to-node HTTP calls previously assembled URLs and selected clients independently, so an extension could not enable one internal TLS transport consistently. This PR adds a target-aware ServiceLoader provider with an OSS fallback and routes FE-to-FE and FE-to-BE URL normalization, URLConnection, Apache HTTP client, RestTemplate, redirect, stream load, configuration, profile, minidump, metadata, and diagnostic call paths through it.
The OSS fallback preserves the existing enable_https behavior for FE endpoints and ordinary HTTP behavior for BE endpoints. Generic non-internal HTTP requests still follow their own URL scheme. When unified HTTP TLS is active, group commit still selects and redirects directly to the group-commit backend; only the optional extra BE-to-BE stream-load forward hop is skipped because that hop is not TLS-aware.
Release note
Add an extension point and complete call-site routing for TLS-aware internal FE and BE HTTP clients.
Check List (For Author)