Repository navigation
chore(csv): use shared aggr_test_schema in CSV scan tests - #26681
Open
ninglinLiu wants to merge 2 commits into
Open
ninglinLiu wants to merge 2 commits into
ninglinLiu wants to merge 2 commits into
Conversation
Drop the private copy in physical_plan/csv.rs tests and call crate::test_util::aggr_test_schema instead. Fixes apache#26306
alamb
enabled auto-merge
October 23, 2026 21:17
Fixes cargo fmt check on apache#26681.
auto-merge was automatically disabled
October 23, 2026 21:37
Head branch was pushed to by a user without write access
alamb
added
the
Prolific Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The CSV physical-plan test module defined a private
aggr_test_schema()that duplicateddatafusion::test_util::aggr_test_schema(). Use the shared helper instead and drop the unusedHashMapimport.Test plan
c1metadata)cargo test -p datafusion --lib csvFixes #26306