Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Related to #25662; this addresses the typed Parquet configuration diagnostic boundary.
Rationale for this change
Formatting Parquet encryption or decryption configuration with
Debugcurrently includes footer and column key material. Nested configuration andParquetFormatdiagnostics can expose the same keys.What changes are included in this PR?
ConfigFileEncryptionProperties,ConfigFileDecryptionProperties,ColumnEncryptionProperties, andColumnDecryptionProperties.What is the testing strategy for this PR?
The configuration tests cover compact and pretty formatting, direct and nested types, unchanged raw configuration values, ordinary column options, and feature-enabled conversion. The DataFrame test writes an encrypted file, verifies exact values and nulls with the correct keys, and rejects wrong-column-key and missing-key reads.
Validation against the updated main branch:
cargo fmt --all --checkcargo clippy --locked --profile ci --all-targets --all-features -- -D warningscargo test --locked --profile ci -p datafusion-common --test encryption_config_debug(7 passed), and with--features parquet_encryption(8 passed).cargo test --locked --profile ci -p datafusion-common --features parquet_encryption(664 unit tests, 8 regression tests and 81 doctests passed; 5 doctests ignored).parquet_integrationencrypted-file roundtrip test passed.RUST_BACKTRACE=1 cargo test --locked --profile ci --exclude datafusion-examples --exclude datafusion-benchmarks --exclude datafusion-cli --workspace --lib --tests --bins --features avro,json,backtrace,extended_tests,recursive_protection,parquet_encryption.As a regression check, running the new default-feature tests with the original
config.rsproduces five assertion failures; restoring the fix makes all seven pass.Are there any user-facing changes?
Debugoutput replaces footer and column key contents with<REDACTED>. Public configuration fields, explicit configuration enumeration and encryption/decryption behavior are unchanged.