Repository navigation
fix: UNNEST now preserves item fields in expression inference and logical-plan schemas - #26433
Merged
Merged
Conversation
…e-apache-datafusion-26331
quwin
marked this pull request as ready for review
October 17, 2026 03:18
Author
|
@jayzhan211 Could you review this |
jayzhan211
self-requested a review
October 19, 2026 12:03
jayzhan211
reviewed
Oct 19, 2026
jayzhan211
approved these changes
Oct 19, 2026
jayzhan211
left a comment
Contributor
There was a problem hiding this comment.
Thanks @quwin , overall LGTM
alamb
enabled auto-merge
October 19, 2026 20:13
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #26433 +/- ##
==========================================
- Coverage 82.93% 82.93% -0.01%
==========================================
Files 1154 1154
Lines 457933 457954 +21
Branches 457933 457954 +21
==========================================
+ Hits 379786 379796 +10
- Misses 55128 55133 +5
- Partials 23019 23025 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
In SedonaDB, unnesting a list of GeoArrow geometries currently returns plain binary values, losing the geometry type and CRS metadata needed by downstream spatial operations; metadata-aware SQL functions can also reject the field during planning.
What changes are included in this PR?
What is the testing strategy for this PR?
logical_unnest_plus_1000_columnsbenchmark in the optimizedrelease-nonltoprofile measured 47.58 ms on base0d79252fand 48.75 ms on this branch (+2.5% median). This is within the noise threshold.Are there any user-facing changes?
UNNEST retains list-item metadata, including Arrow extension metadata, in inferred fields and result schemas. No public Rust API changes.