Skip to content

feat: tests for nan and nulls in percentile and median UDAF - #24580

Open
theirix wants to merge 1 commit into
apache:mainfrom
theirix:percentile-nan-behaviour
Open

feat: tests for nan and nulls in percentile and median UDAF#24580
theirix wants to merge 1 commit into
apache:mainfrom
theirix:percentile-nan-behaviour

Conversation

@theirix

@theirix theirix commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

Rationale for this change

I recently refined null support for median / percentile_cont and their approximate counterparts approx_median, appprox_percentile_cont`

With the following tests for NaN for percentiles, the behaviour of all four functions for NaN and nulls is defined and covered by tests in aggregate.slt

What changes are included in this PR?

Missing tests for NaN for two functions

Are these changes tested?

Verified with DuckDB and PostgreSQL

Are there any user-facing changes?

@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Aug 22, 2026
@theirix
theirix marked this pull request as ready for review August 22, 2026 13:39
@codecov-commenter

codecov-commenter commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.37%. Comparing base (32badcb) to head (6c36e88).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main   #24580    +/-   ##
========================================
  Coverage   81.37%   81.37%            
========================================
  Files        1116     1116            
  Lines      397509   397661   +152     
  Branches   397509   397661   +152     
========================================
+ Hits       323461   323591   +130     
- Misses      55110    55126    +16     
- Partials    18938    18944     +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review NaN handling in median and approx_median

2 participants