feat: tests for nan and nulls in percentile and median UDAF - #24580
Open
theirix wants to merge 1 commit into
Open
feat: tests for nan and nulls in percentile and median UDAF#24580theirix wants to merge 1 commit into
theirix wants to merge 1 commit into
Conversation
theirix
marked this pull request as ready for review
August 22, 2026 13:39
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24580 +/- ##
========================================
Coverage 81.37% 81.37%
========================================
Files 1116 1116
Lines 397509 397661 +152
Branches 397509 397661 +152
========================================
+ Hits 323461 323591 +130
- Misses 55110 55126 +16
- Partials 18938 18944 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
NaNhandling inmedianandapprox_median#3039.Rationale for this change
I recently refined null support for
median/percentile_contand their approximate counterpartsapprox_median,appprox_percentile_cont`With the following tests for
NaNfor percentiles, the behaviour of all four functions forNaNand nulls is defined and covered by tests inaggregate.sltWhat changes are included in this PR?
Missing tests for
NaNfor two functionsAre these changes tested?
Verified with DuckDB and PostgreSQL
Are there any user-facing changes?