feat: widen percentile input to use larger precision - #24577
Open
theirix wants to merge 2 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24577 +/- ##
========================================
Coverage 81.37% 81.37%
========================================
Files 1116 1116
Lines 397509 397663 +154
Branches 397509 397663 +154
========================================
+ Hits 323461 323592 +131
- Misses 55110 55124 +14
- Partials 18938 18947 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
theirix
marked this pull request as ready for review
August 22, 2026 12:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Decimal32with lower interpolation precision #24576Rationale for this change
A follow-up for #24419, which introduced pure-decimal interpolation, where a smaller interpolation precision was used for
Decimal32types with Euclidean interpolation. Seems like, a smaller precision forDecimal32is not enough, and the value was saturated to zero.Solution - just widen
i32inputs toi64to handle edge cases. In this case, we can use the same logical interpolation precision10^6everywhere.What changes are included in this PR?
scale_by_numnow widensi32inputs toi64Are these changes tested?
Are there any user-facing changes?