Skip to content

PostgreSQL: Parse schema-qualified keyword function calls - #2685

Open
LucaCappelletti94 wants to merge 1 commit into
mainfrom
upstream/qualified-keyword-cleanup
Open

LucaCappelletti94 wants to merge 1 commit into
mainfrom
upstream/qualified-keyword-cleanup

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

The parser rejects SELECT public.floor(3) and SELECT pg_catalog.floor(3) because the suffix fallback consumes the keyword as an identifier. Qualified keyword names require ordinary function-call parsing with their full names preserved, consistent with PostgreSQL's function resolution rules.

Bare FLOOR(3) and keyword column references such as t.interval retain their expression forms.

@LucaCappelletti94 LucaCappelletti94 added bug Something isn't working PostgreSQL labels Oct 19, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.31%. Comparing base (d32825d) to head (2d90049).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2685      +/-   ##
==========================================
+ Coverage   81.29%   81.31%   +0.01%     
==========================================
  Files          42       42              
  Lines       33950    33953       +3     
  Branches    33950    33953       +3     
==========================================
+ Hits        27601    27608       +7     
+ Misses       2785     2782       -3     
+ Partials     3564     3563       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working PostgreSQL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants