Repository navigation
PostgreSQL: Parse schema-qualified keyword function calls - #2685
Open
LucaCappelletti94 wants to merge 1 commit into
Open
LucaCappelletti94 wants to merge 1 commit into
LucaCappelletti94 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2685 +/- ##
==========================================
+ Coverage 81.29% 81.31% +0.01%
==========================================
Files 42 42
Lines 33950 33953 +3
Branches 33950 33953 +3
==========================================
+ Hits 27601 27608 +7
+ Misses 2785 2782 -3
+ Partials 3564 3563 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser rejects
SELECT public.floor(3)andSELECT pg_catalog.floor(3)because the suffix fallback consumes the keyword as an identifier. Qualified keyword names require ordinary function-call parsing with their full names preserved, consistent with PostgreSQL's function resolution rules.Bare
FLOOR(3)and keyword column references such ast.intervalretain their expression forms.