Make clickhouse tuples work#2337
Conversation
d63268b to
db8e97a
Compare
|
note. this PR does not address
source: https://clickhouse.com/docs/sql-reference/functions/tuple-functions#tupleelement |
| // After a Word, RBracket, or RParen, `.<digit>` is split into `Period` | ||
| // and a separate integer `Number`, so the parser can build a | ||
| // CompoundFieldAccess instead of seeing a single decimal literal. | ||
| dialects.tokenizes_to( |
There was a problem hiding this comment.
not sure I follow the patch/tests - are we saying that without this PR, a sql like t.1 tokenizes to something other than what's being asserted (if so what does the previous behavior tokenized to)?
| true | ||
| } | ||
|
|
||
| /// See <https://clickhouse.com/docs/sql-reference/functions/tuple-functions#tupleelement> |
There was a problem hiding this comment.
does this behavior differ from parse_compound_expr handling (if so how, on a first glance they look identical syntax wise)?
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
closes #2338