Repository navigation
docs: apply the style guide's "native" rules to timezones.md - #7477
Open
Abhishek-Mohan wants to merge 1 commit into
Open
Abhishek-Mohan wants to merge 1 commit into
Abhishek-Mohan wants to merge 1 commit into
Conversation
Replace the phrases the style guide rules out (N1, N3) with the term each one means: "runs natively", "not handled natively", "the native path", "a native path" and "ran natively" become what Comet does in Rust, and "native expression", "native spelling" and "native version" name the Rust expression, the `Tz::from_str` parser and the native library's IANA database version. The `date_format` sentence also said Comet uses `to_char` only in UTC sessions. `CometDateFormat` also uses it in other sessions when `spark.comet.expression.DateFormatClass.allowIncompatible=true`, so the sentence now says so. Part of apache#7358. Generated-by: OpenCode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7358. This PR moves
contributor-guide/timezones.mdover; the other pages stay open in that issue.Rationale for this change
The style guide from #7151 rules out "runs natively", "the native path" and similar phrases (
N1), and, in the contributor guide, allows "native" before a noun only when it names something undernative/or the JNI boundary (N3).timezones.mdwas one of the pages named in the #7151 review as still using them.What changes are included in this PR?
One page,
docs/source/contributor-guide/timezones.md, eight wording changes:N3date_formatruns natively only in UTC sessionsto_charfordate_formatonly in UTC sessions, unlessspark.comet.expression.DateFormatClass.allowIncompatible=trueN1,P16Tz::from_stracceptsN3getTzdataVersion)getTzdataVersion)N3N1N1N1N1The
date_formatrow also fixes a claim:CometDateFormat.convertusesto_charoutside UTC when the expression'sallowIncompatibleconfig is set.The last row says "in Rust" rather than "in the Comet pipeline" because the sentence contrasts the Rust implementation with codegen dispatch, which also stays in the Comet pipeline.
Uses the guide allows are unchanged: "native code", "native side", "native plan", "native kernel", "native scan", "native implementation", the JVM/native boundary, and
expect_native(N2,N3,N6).How are these changes tested?
Documentation only.
CometDateFormatandCometConf.getExprAllowIncompatConfigKey(spark/.../serde/datetime.scala,CometConf.scala),CometTimeZone.nativeId, andNativeBase.getTzdataVersionwith its Rust side innative/core/src/lib.rs.prettier --checkpasses on the changed page.-n) at the base and at the head: 32 warnings on each, none new, none on this page.AI assistance: written with Claude Opus 5.5 through OpenCode.