perf: reuse Arrow IPC compression context across shuffle blocks - #5038
Open
peterxcli wants to merge 1 commit into
Open
perf: reuse Arrow IPC compression context across shuffle blocks#5038peterxcli wants to merge 1 commit into
peterxcli wants to merge 1 commit into
Conversation
Member
|
Thanks @peterxcli. Can you share any benchmark results? |
Member
Author
|
@andygrove this would take effect only after #4888 is merged. with arrow 58.4:
with arrow 59.1:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #5008.
Rationale for this change
Avoid recreating Arrow IPC compression state for every shuffle block.
What changes are included in this PR?
Reuse one
CompressionContextper buffered partition writer and across batches in the JVM row conversion path. Update benchmarks and callers accordingly.How are these changes tested?
Existing shuffle IPC round-trip, buffered writer, and shuffle scan tests pass. The shuffle writer benchmark also compiles successfully.