Repository navigation
Open
Labels
bugSomething isn't workingSomething isn't workingpriority:lowMinor issues, test failures, tooling, cosmeticMinor issues, test failures, tooling, cosmeticrequires-triage
Description
Part of #7267.
These came out of the same audit as the other new sub-issues. Each needs an opt-in feature, sizes that are unlikely in practice, or a fix upstream, so they are collected here instead of filed one by one.
Line references are for main at 4e6b122, DataFusion 55.2.0 and arrow 59.3.2.
Comet
- The native Iceberg writer (opt-in) concatenates pending pieces into 1000-row units (
native/core/src/execution/operators/iceberg_write.rs:1897-1909,ROWS_DIVISORat:727). Values averaging more than about 2.1 MB in one column overflow a unit withOffsetOverflowError. Iceberg's Java writer writes one row at a time. -
FixedWidthArrowFieldWriter.writeArrayElementscallsensureCapacity(count + numElements)with Int arithmetic (ArrowWriters.scala:980-1005). Past 2^31 elements in one batch the sum goes negative, the buffer is not grown, andcopyMemorywrites past its end. Comet setsarrow.enable_unsafe_memory_access=true(NativeBase.java:228), so Arrow's own bounds checks don't catch it.Math.addExactwould. - Importing JVM strings with invalid UTF-8 decodes them with U+FFFD, up to 3x the bytes, through a builder that panics on overflow (
native/common/src/utf8.rs:236-245). - DataFusion UDF results of type
Utf8View/BinaryVieware cast back with arrow'scast_view_to_byte(native/core/src/execution/planner.rs:2227-2244), which panics on overflow instead of returning an error. - Past 2^31 list elements in one batch, these panic instead of returning an error:
array_insert(array_insert.rs:309),arrays_zip(arrays_zip.rs:295),percentile(percentile.rs:205-206),pivot_first(pivot_first.rs:536-537). -
CometScalaUDFCodegen.estimatedOutputBytessums input sizes as an Int (CometScalaUDFCodegen.scala:294-308), so inputs over 2 GiB give a wrong preallocation size. -
Utils.narrowOffsets(Utils.scala:791-805) fails broadcast and cache serialization for a large-offset column over 2 GiB, for example frommapInArrowwith large variable-width types. -
ConstantColumnVectors.materialize(ArrowWriters.scala:129-143) writes a constant once per row with no size limit, the JVM side of Native execution fails with offset overflow when a large scalar string is expanded to the batch length #7247. In practice these constants are small partition and default values.
Upstream
- arrow's
MapBuilder::appendpusheskey_builder.len() as i32without a check (arrow-arraysrc/builder/map_builder.rs:176), andfinishbuilds the array unchecked (:277). Past 2^31 entries in one batch the offsets wrap silently. Comet reaches it throughstr_to_map(datafusion-spark) and the JVM shuffle's map conversion (native/shuffle/src/spark_unsafe/row.rs:1234). - parquet's DELTA_LENGTH_BYTE_ARRAY decoder panics on offset overflow (
src/arrow/array_reader/byte_array.rs:514), where the other decoders return an error. - arrow-csv builds each string column with
collect::<StringArray>()(src/reader/mod.rs:872-879), which panics past 2 GiB. Comet's native CSV scan is opt-in. - DataFusion's sort-merge join pushes to its
BatchCoalescerwith.expect(...)(src/joins/sort_merge_join/materializing_stream.rs:465,:505,:516), so a coalescer overflow (Offset overflow - Byte limit in arrow BatchCoalescer and DataFusion LimitedBatchCoalescer (upstream) #7271) panics instead of failing with an error.
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingpriority:lowMinor issues, test failures, tooling, cosmeticMinor issues, test failures, tooling, cosmeticrequires-triage
Activity