Add sensible defaults to StaxUtils's MAX_ELEMENT_COUNT and MAX_XML_CHARACTERS - #3463
Open
reta wants to merge 1 commit into
Open
Add sensible defaults to StaxUtils's MAX_ELEMENT_COUNT and MAX_XML_CHARACTERS#3463reta wants to merge 1 commit into
reta wants to merge 1 commit into
Conversation
reta
commented
Sep 13, 2026
| getInteger(MIN_TEXT_SEGMENT, 64); // Same default as woodstox | ||
| private static final long MAX_ELEMENT_COUNT_VAL = | ||
| getLong(MAX_ELEMENT_COUNT, Long.MAX_VALUE); | ||
| // The MAX_XML_CHARACTERS should be aligned with MAX_TEXT_LENGTH (maximum contiguous length of any character |
Member
Author
There was a problem hiding this comment.
@coheigea it is difficult to come up with the right defaults here, but:
- MAX_TEXT_LENGTH is set to 128Mb, so MAX_XML_CHARACTERS is set to at least 2x of that
- MAX_ELEMENT_COUNT should be larger than MAX_CHILD_ELEMENTS (it is included), so setting it to be at least 10x of MAX_CHILD_ELEMENTS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add sensible defaults to StaxUtils's MAX_ELEMENT_COUNT and MAX_XML_CHARACTERS