Fix inverted fixed-size guard in FixedSizeSortedMap.putAll - #722
Merged
garydgregory merged 2 commits intoAug 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes FixedSizeSortedMap.putAll to correctly reject inserts of new keys into a fixed-size map while still allowing value updates for existing keys, aligning behavior with the fixed-size decorator contract and the sibling FixedSizeMap.putAll.
Changes:
- Invert the
CollectionUtils.isSubCollectionguard inFixedSizeSortedMap.putAllso only new keys are rejected. - Add a focused JUnit test covering: existing-key updates, empty
putAllno-op, and rejection of new keys without growing the map.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main/java/org/apache/commons/collections4/map/FixedSizeSortedMap.java | Corrects putAll guard condition to prevent adding new keys to a fixed-size sorted map. |
| src/test/java/org/apache/commons/collections4/map/FixedSizeSortedMapTest.java | Adds regression test ensuring putAll allows updates but rejects new keys and preserves size. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
garydgregory
added a commit
that referenced
this pull request
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
putAllinverted theisSubCollectioncheck so it rejected legal value updates and let a new key grow the fixed-size map; negate it to match siblingFixedSizeMap.putAll, spotted while auditing the fixed-size decorators.mvn; that'smvnon the command line by itself.