Skip to content

add test ldap test command and button - #13954

Open
DaanHoogland wants to merge 1 commit into
mainfrom
ghi6934-test-ldap-connection
Open

add test ldap test command and button#13954
DaanHoogland wants to merge 1 commit into
mainfrom
ghi6934-test-ldap-connection

Conversation

@DaanHoogland

Copy link
Copy Markdown
Contributor

Description

This PR...

Fixes: #6934

a new test ldap connection command and button.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 55.35714% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.74%. Comparing base (5e5ae0c) to head (c8a8518).

Files with missing lines Patch % Lines
...oudstack/api/command/LdapTestConfigurationCmd.java 36.66% 18 Missing and 1 partial ⚠️
...va/org/apache/cloudstack/ldap/LdapManagerImpl.java 76.92% 5 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #13954      +/-   ##
============================================
+ Coverage     19.72%   19.74%   +0.01%     
- Complexity    19941    19962      +21     
============================================
  Files          6371     6372       +1     
  Lines        575738   575782      +44     
  Branches      70471    70472       +1     
============================================
+ Hits         113582   113671      +89     
+ Misses       449810   449754      -56     
- Partials      12346    12357      +11     
Flag Coverage Δ
uitests 3.41% <ø> (+<0.01%) ⬆️
unittests 21.02% <55.35%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud

Copy link
Copy Markdown

@github-actions

Copy link
Copy Markdown

🔴 Test Coverage Grade: D — Marginal

Metric Value
Line coverage 24.61%
Branch coverage 18.81%

Grade Scale

Grade Line Coverage Meaning
🟢 A ≥ 80% Excellent - this code sleeps well at night 😴
🟡 B 60-79% Good - almost there, don't stop now 😉
🟠 C 40-59% Acceptable - your code is wearing a seatbelt, but no airbags 😬
🔴 D 20-39% Marginal - boldly shipping where no test has gone before 🖖
⛔ F < 20% Failing - tests? what tests? 🔥

Branch coverage is shown as a secondary signal. Grade is determined by line coverage.
View full Actions run

@DaanHoogland
DaanHoogland force-pushed the ghi6934-test-ldap-connection branch from c8a8518 to e031775 Compare August 22, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test button addition in Domains LDAP config

1 participant