Skip to content

make sure pre saml login is enabled after saml is disabled - #13953

Open
DaanHoogland wants to merge 1 commit into
mainfrom
ghi12595-saml-disable-ldap-fallback
Open

make sure pre saml login is enabled after saml is disabled#13953
DaanHoogland wants to merge 1 commit into
mainfrom
ghi12595-saml-disable-ldap-fallback

make sure pre saml login is enabled after saml is disabled

bc42cd1
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Aug 22, 2026 in 2m 31s

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 152 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fk&open=AaArJ3x7rd49U0dPV8fk&pullRequest=13953

Check warning on line 164 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fn&open=AaArJ3x7rd49U0dPV8fn&pullRequest=13953

Check warning on line 139 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "verify". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fi&open=AaArJ3x7rd49U0dPV8fi&pullRequest=13953

Check failure on line 456 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ31krd49U0dPV8fq&open=AaArJ31krd49U0dPV8fq&pullRequest=13953

Check warning on line 148 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fj&open=AaArJ3x7rd49U0dPV8fj&pullRequest=13953

Check warning on line 127 in plugins/user-authenticators/saml2/src/main/java/org/apache/cloudstack/saml/SAML2AuthManagerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this field injection and use constructor injection instead. 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ31krd49U0dPV8fp&open=AaArJ31krd49U0dPV8fp&pullRequest=13953

Check warning on line 152 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "never". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fl&open=AaArJ3x7rd49U0dPV8fl&pullRequest=13953

Check warning on line 171 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fo&open=AaArJ3x7rd49U0dPV8fo&pullRequest=13953

Check warning on line 135 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fh&open=AaArJ3x7rd49U0dPV8fh&pullRequest=13953

Check warning on line 157 in plugins/user-authenticators/saml2/src/test/java/org/apache/cloudstack/SAML2AuthManagerImplTest.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use a static import for "when". 

See more on https://sonarcloud.io/project/issues?id=apache_cloudstack&issues=AaArJ3x7rd49U0dPV8fm&open=AaArJ3x7rd49U0dPV8fm&pullRequest=13953
View more details on SonarQubeCloud