allow linking a domain to a LDAP when it was already used before - #13948
Open
DaanHoogland wants to merge 2 commits into
Open
allow linking a domain to a LDAP when it was already used before#13948DaanHoogland wants to merge 2 commits into
DaanHoogland wants to merge 2 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13948 +/- ##
============================================
+ Coverage 16.32% 16.34% +0.02%
- Complexity 13556 13582 +26
============================================
Files 5669 5669
Lines 501399 501436 +37
Branches 60902 60909 +7
============================================
+ Hits 81847 81980 +133
+ Misses 410390 410285 -105
- Partials 9162 9171 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…new one to be linked instead
|
DaanHoogland
commented
Aug 22, 2026
| LdapTrustMapVO oldVo = _ldapTrustMapDao.findByDomainId(domainId); | ||
| if (oldVo != null) { | ||
| ensureOldDomainMappingNotInUse(domainId, oldVo); | ||
| logger.warn(String.format("domain %d is already linked to ldap %s '%s'; replacing with the new mapping", domainId, oldVo.getType(), oldVo.getName())); |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| logger.warn(String.format("domain %d is already linked to ldap %s '%s'; replacing with the new mapping", domainId, oldVo.getType(), oldVo.getName())); | |
| logger.warn("domain {} is already linked to ldap {} ‘{}'; replacing with the new mapping", domainId, oldVo.getType(), oldVo.getName()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR...
Fixes: #11471
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?