Fix stg access group validation#13562
Draft
Pearl1594 wants to merge 5 commits into
Draft
Conversation
* VM Migration: Storage access groups validation issue fix * Refactor list empty checks --------- Co-authored-by: Sachin R Doddaguni <s_rudrappadoddagu@apple.com>
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## 4.22 #13562 +/- ##
=============================================
- Coverage 17.67% 3.69% -13.98%
=============================================
Files 5923 448 -5475
Lines 533349 38117 -495232
Branches 65248 7067 -58181
=============================================
- Hits 94253 1409 -92844
+ Misses 428437 36521 -391916
+ Partials 10659 187 -10472
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
added 2 commits
July 7, 2026 14:14
…stg-access-group-validation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the below issue:
VM migration fails with “Storage access groups on the source and destination hosts did not match” if list of storage access groups does not match.
Steps to reproduce:
Expected result:
VM migrated as there is common storage access group, where ROOT volume created from (aced).
Observed result:
Storage access groups on the source and destination hosts did not match.
It just simply checks collections [legacy, aced] and [aced] should be equal.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?