Skip to content

Redact sensitive duplicate query parameter values in ApiServlet logs#13559

Open
dheeraj12347 wants to merge 2 commits into
apache:mainfrom
dheeraj12347:fix-redact-sensitive-duplicate-params
Open

Redact sensitive duplicate query parameter values in ApiServlet logs#13559
dheeraj12347 wants to merge 2 commits into
apache:mainfrom
dheeraj12347:fix-redact-sensitive-duplicate-params

Conversation

@dheeraj12347

Copy link
Copy Markdown
Contributor

Summary

This PR fixes a sensitive information disclosure issue in ApiServlet where duplicate sensitive query parameter values were logged in plaintext before authentication.

Previously, when duplicate query parameters such as password were received, checkSingleQueryParameterValue() logged all values using Arrays.toString(...), which could expose sensitive information in management logs even if the request was later rejected.

Changes

  • Redacted duplicate values for sensitive query parameters before logging.
  • Introduced a shared helper to identify sensitive parameter names.
  • Reused the helper in getCleanParamsString() to avoid duplicating sensitive parameter detection logic.
  • Preserved the existing duplicate-parameter warning behavior for non-sensitive parameters.
  • Added regression tests covering both sensitive and non-sensitive parameter handling.

Testing

  • Verified that duplicate sensitive parameters are logged as [REDACTED, REDACTED].
  • Verified that duplicate non-sensitive parameters continue to be logged unchanged.
  • Added unit tests for sensitive parameter detection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant