Add per-domain OAuth (Google, GitHub) provider support by Damans227 · Pull Request #12702 · apache/cloudstack

Damans227 · 2026-02-25T00:34:20Z

Description

Add per-domain OAuth provider support. Allows OAuth providers (Google, GitHub) to be configured at the domain level with global fallback.

Doc PR : apache/cloudstack-documentation#647

Design Doc

https://cwiki.apache.org/confluence/display/CLOUDSTACK/Allow+OAuth+provider+per+domain

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Screenshots and recording

Screen.Recording.2026-03-16.at.10.34.53.AM.mp4

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

How Has This Been Tested?

Manual testing with GitHub OAuth provider configured at domain level and global level, verifying domain-specific lookup with global fallback.

…DBUtils

…ove code clarity

…entication checks

…nid' in columns and details

…nhance user verification

…ls for improved readability and consistency

…istency

…cation method

…mmand classes

Damans227 · 2026-02-25T00:52:50Z

@blueorangutan package

blueorangutan · 2026-02-25T00:54:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-02-25T01:27:14Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 16931

Damans227 · 2026-02-25T01:42:50Z

@blueorangutan package

weizhouapache · 2026-06-23T14:36:30Z

@Damans227
can you fix the conflicts with #13033 ?

Damans227 · 2026-06-23T14:47:20Z

@Damans227 can you fix the conflicts with #13033 ?

On it.

Damans227 · 2026-06-23T15:13:47Z

@blueorangutan package

blueorangutan · 2026-06-23T15:16:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-23T16:10:04Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18350

Damans227 · 2026-06-23T17:34:24Z

@Damans227 can you fix the conflicts with #13033 ?

Fixed it.

github-actions · 2026-06-24T11:15:31Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Damans227 · 2026-06-24T11:57:18Z

@blueorangutan package

blueorangutan · 2026-06-24T11:58:04Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-06-24T13:05:31Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18363

github-actions · 2026-07-02T18:45:58Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Damans227 · 2026-07-02T19:57:59Z

@blueorangutan package

blueorangutan · 2026-07-02T20:00:05Z

@Damans227 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-07-02T21:40:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18446

weizhouapache · 2026-07-08T09:07:04Z

@Damans227 @harikrishna-patnala
can you discuss if we can merge this PR ?

weizhouapache · 2026-07-08T14:02:15Z

@blueorangutan package

blueorangutan · 2026-07-08T14:04:05Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-07-08T14:52:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✖️ debian ✔️ suse15. SL-JID 18498

Daman Arora and others added 19 commits December 18, 2025 11:23

Add domain_id to oauth_provider table and VO

dfc45c0

Add domain-aware methods to OauthProviderDao

fcb4778

Add domainId parameter to OAuth provider API commands and response

85c64e5

Add domain support to OAuth2AuthManager

c46fb98

Add domain-aware OAuth verification

4ef100c

Add domain support to ListOAuthProvidersCmd and update related tests

8e48938

fix domain path issue

9ab26db

Add domainId support to OAuth provider

3e7fa92

Return domain name and UUID in OAuth provider API responses using Api…

4a6b28e

…DBUtils

Refactor domain ID resolution in VerifyOAuthCodeAndGetUserCmd to impr…

3ab3ca9

…ove code clarity

Enhance OAuth2 plugin support for domain-level configuration and auth…

bb6f137

…entication checks

Update OAuth2 tests and VerifyOAuthCodeAndGetUserCmdTest

764495b

Add method to find OAuth provider by domain with global fallback

0ec6bcc

Update OAuth provider configuration to use 'domain' instead of 'domai…

9609ef0

…nid' in columns and details

Refactor OAuth provider methods to support domain-level queries and e…

65ccef1

…nhance user verification

Add caching for access token retrieval in GithubOAuth2Provider

e3da679

Refactor access token checks in GithubOAuth2Provider to use StringUti…

0e32a60

…ls for improved readability and consistency

Refactor null checks to use utility for improved readability and cons…

23c4132

…istency

Update OAuth2UserAuthenticatorTest to include domainId in user verifi…

1a23f3a

…cation method

boring-cyborg Bot added component:api component:UI labels Feb 25, 2026

Damans227 added 2 commits February 24, 2026 19:42

Merge branch 'main' into oauth-per-domain

b8cf181

Remove unnecessary blank line and unused imports in OAuth provider co…

6d73964

…mmand classes

Damans227 added 2 commits February 24, 2026 20:13

Refactor and cleanup

a428d1a

Remove unnecessary blank lines

b367434

Enhance RegisterOAuthProviderCmdTest with additional provider mock data

42a8651

Merge remote-tracking branch 'upstream/main' into oauth-per-domain

7d18998

github-actions Bot removed the status:has-conflicts label Jun 23, 2026

github-actions Bot added the status:has-conflicts label Jun 24, 2026

Damans227 added 2 commits June 24, 2026 07:51

Enhance OAuth tab icons with disabled state styling for better UX

c2ca9e6

Merge branch 'main' into oauth-per-domain

d9748b0

github-actions Bot removed the status:has-conflicts label Jun 24, 2026

weizhouapache added the status:ready-for-merge label Jun 29, 2026

github-actions Bot added the status:has-conflicts label Jul 2, 2026

Damans227 added 2 commits July 2, 2026 15:53

Add domain-specific provider prompt and update OAuth provider handling

18cf904

Merge branch 'main' into oauth-per-domain

5696366

github-actions Bot removed the status:has-conflicts label Jul 2, 2026

Merge branch 'main' into oauth-per-domain

a747fb7

Uh oh!

Conversation

Damans227 commented Feb 25, 2026 • edited by harikrishna-patnala Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Design Doc

Types of changes

Screenshots and recording

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

How Has This Been Tested?

Uh oh!

Damans227 commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 25, 2026

Uh oh!

blueorangutan commented Feb 25, 2026

Uh oh!

Damans227 commented Feb 25, 2026

Uh oh!

weizhouapache commented Jun 23, 2026

Uh oh!

Damans227 commented Jun 23, 2026

Uh oh!

Damans227 commented Jun 23, 2026

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

blueorangutan commented Jun 23, 2026

Uh oh!

Damans227 commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 24, 2026

Uh oh!

Damans227 commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

blueorangutan commented Jun 24, 2026

Uh oh!

github-actions Bot commented Jul 2, 2026

Uh oh!

Damans227 commented Jul 2, 2026

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

blueorangutan commented Jul 2, 2026

Uh oh!

weizhouapache commented Jul 8, 2026

Uh oh!

weizhouapache commented Jul 8, 2026

Uh oh!

blueorangutan commented Jul 8, 2026

Uh oh!

blueorangutan commented Jul 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Damans227 commented Feb 25, 2026 •

edited by harikrishna-patnala

Loading