Conversation
…e seed Introduces QTRandom to bridge QT's RandomnessSource into Java Random API Patch by Yifan Cai; Reviewed by TBD for CASSANALYTICS-195
yifan-c
commented
Sep 2, 2026
Comment on lines
+34
to
+48
| public final class QTRandom extends Random | ||
| { | ||
| private final RandomnessSource source; | ||
|
|
||
| public QTRandom(RandomnessSource source) | ||
| { | ||
| this.source = source; | ||
| } | ||
|
|
||
| @Override | ||
| protected int next(int bits) | ||
| { | ||
| return (int) source.next(Constraint.between(0, (1L << bits) - 1)); | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This class is the core of the patch. The other test code are modified to take QTRandom instead of Random.
bbotella
reviewed
Sep 14, 2026
| private boolean shouldCdcEventWriterFailOnProcessing = false; | ||
| private CdcOptions cdcOptions; | ||
| private CassandraSource cassandraSource = CassandraSource.DEFAULT; | ||
| private Random random = new Random(); |
Contributor
There was a problem hiding this comment.
Nit: Maybe moving this inside the builder to avoid instantiating Random if it is not needed? Just like we do with CdcOptions.
| Random first = new QTRandom(new FixedSequenceSource(1L)); | ||
| Random second = new QTRandom(new FixedSequenceSource(2L)); | ||
|
|
||
| assertThat(first.nextLong()).isNotEqualTo(second.nextLong()); |
Contributor
There was a problem hiding this comment.
This is "technically" flaky :-P
But let's keep it as is. It would be REAL bad luck to hit it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces QTRandom to bridge QT's RandomnessSource into Java Random API
Patch by Yifan Cai; Reviewed by TBD for CASSANALYTICS-195