Beam SQL: name query composites after what was fused into them - #39908
Draft
kennknowles wants to merge 1 commit into
Draft
Beam SQL: name query composites after what was fused into them#39908kennknowles wants to merge 1 commit into
kennknowles wants to merge 1 commit into
Conversation
Beam SQL named each composite it expands a query into after the relational node class and a JVM-global counter, e.g. BeamCalcRel_57. That counter was global, so the same query produced different names on different runs, and the names said nothing about what the stage does. Name a stage after the operations fused into it instead, e.g. Filter;Project. The provenance label rides along as a RelHint so that it survives copy() and the conversion to physical rels, and is composed as a canonical union of the labels of the nodes a rule matched -- order independent, so transpose rules trading a pair back and forth cannot hand the planner an endless supply of rels it has not seen. Since Dataflow matches streaming pipelines for update by step name, the experiment legacy-sql-transform-names restores the old naming for pipelines that need to be updated across this change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Beam SQL named each composite it expands a query into after the relational node class and a JVM-global counter, e.g. BeamCalcRel_57. That counter was global, so the same query produced different names on different runs, and the names said nothing about what the stage does.
Name a stage after the operations fused into it instead, e.g. Filter;Project. The provenance label rides along as a RelHint so that it survives copy() and the conversion to physical rels, and is composed as a canonical union of the labels of the nodes a rule matched -- order independent, so transpose rules trading a pair back and forth cannot hand the planner an endless supply of rels it has not seen.
Since Dataflow matches streaming pipelines for update by step name, the experiment legacy-sql-transform-names restores the old naming for pipelines that need to be updated across this change.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.