[#39900] Fix MongoDbIO read splitting to preserve non-ObjectId _id types - #39901
Open
ogiogidayo wants to merge 1 commit into
Open
[#39900] Fix MongoDbIO read splitting to preserve non-ObjectId _id types#39901ogiogidayo wants to merge 1 commit into
ogiogidayo wants to merge 1 commit into
Conversation
ogiogidayo
marked this pull request as ready for review
August 27, 2026 09:33
splitKeysToFilters formatted split boundaries unconditionally as
ObjectId("..."), so collections keyed by non-ObjectId ids (e.g.
application-defined string ids) failed to parse the generated range
filters when splitting was enabled via bucketAuto or numSplits.
Serialize boundaries with their actual BSON types instead, and keep
the raw id type in splitKeysToMatch as well.
Fixes apache#39900
ogiogidayo
force-pushed
the
mongodbio-non-objectid-split-39900
branch
from
August 27, 2026 09:40
0ef7358 to
e152ecc
Compare
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39900.
BoundedMongoDbSource.splitKeysToFiltersformatted split boundaries unconditionally asObjectId("..."), so collections keyed by non-ObjectId_idvalues (e.g. application-defined string ids, which MongoDB fully supports) failed withIllegalArgumentException: state should be: hexString has 24 charactersas soon as read splitting was enabled viawithBucketAuto(true)orwithNumSplits(n). The AggregationQuery path (splitKeysToMatch) had the same assumption viagetObjectId("_id").This change serializes split boundaries with their actual BSON types:
splitKeysToFiltersnow builds the range filters asDocuments and serializes them withDocument#toJson(extended JSON). ObjectId boundaries keep producing semantically identical filters, while string/integer ids are preserved.splitKeysToMatchkeeps the raw_idvalue instead of reading it as an ObjectId. The generated$matchdocuments for ObjectId ids are unchanged (the pre-existing expectations intestSplitIntoBucketpass without modification).Backward compatible: no public API change. Note that
testSplitIntoFilterspreviously asserted output that could never be parsed back (ObjectId("56")for an Integer id, which only passed because the test compared strings without parsing them); it now verifies the generated filters by parsing them. Added string-id tests for both paths.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.