[PubsubIO] Account for message metadata in bounded write batch size - #39886
Open
1fanwang wants to merge 1 commit into
Open
[PubsubIO] Account for message metadata in bounded write batch size#398861fanwang wants to merge 1 commit into
1fanwang wants to merge 1 commit into
Conversation
Signed-off-by: 1fanwang <1fannnw@gmail.com>
Contributor
|
Assigning reviewers: R: @kennknowles for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bounded PubsubIO writes size each batch from the message payload alone. Attributes and ordering keys are omitted, so the writer can publish a batch larger than
maxPublishBatchByteSize.validatePubsubMessagealready returns the validated size of the payload, ordering key, and attributes. The bounded writer now uses that value instead of discarding it and recalculatingmessageSizefrom the payload.This does not address #31800. Its existing TODOs cover JSON versus Protobuf encoding and HTTP to gRPC transcoding.
Fixes #28011
Testing
The regression sends two 27-byte messages through the real bounded-writer lifecycle with a 40-byte batch limit and captures each publish call. To reproduce against base
13875fc6bd3d5ad534c89d33f2395176fbc485fcwhile keeping the regression test from this branch:Both messages were sent in one batch:
After the fix:
The captured batch sizes are now
[1, 1], so neither publish exceeds the configured limit. The fullPubsubIOTestclass also passes with the same Gradle task and the class-level test selector.CHANGES.mdis unchanged for this small bug fix.