Conversation
f6a0e70 to
a50418b
Compare
|
|
||
| # Netty 4.2 only uses Unsafe on JDK 24+ when it's explicitly permitted. However, the broker uses some Unsafe operations | ||
| # via Netty so we must enable it. The option is unrecognized before JDK 23, so it's only added when recognized. | ||
| $JAVACMD --sun-misc-unsafe-memory-access=allow --version > /dev/null 2>&1 && ALLOW_UNSAFE="--sun-misc-unsafe-memory-access=allow" |
There was a problem hiding this comment.
I think this line needs to be added to artemis-distribution/src/main/resources/bin/artemis as well (and I guess the .cmd equivalent also), otherwise the journal auto tune throws a java.lang.UnsupportedOperationException
It might also be worth to consider the addition of --enable-native-access=ALL-UNNAMED here and in the artemis-utility.profile file to get rid of the otherwise quite repetitive warning message:
WARNING: A restricted method in java.lang.System has been called
WARNING: java.lang.System::loadLibrary has been called by io.netty.util.internal.NativeLibraryUtil in an unnamed module (file:/...../apache-artemis-2.58...../lib/netty-common-4.2.17.Final.jar)
WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for callers in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled
|
Very nice work with this @jbertram ! |
No description provided.