Repository navigation
Conversation
added 2 commits
November 10, 2026 19:44
Add a ProjectRel test using case_when, which computes its output type from its inputs. Check the converted schema and query results. The test aborts without other changes.
OutputType::type() is only valid for fixed kernel outputs. Use the type resolved by Bind for the projected field instead. This fixes the assert in the test in the previous commit
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
ProjectRelconversion callsOutputType::type()on the kernel signature which only supports fixed output types.Valid expressions such as
case_whencompute their output types from their inputs. Deserializing these projections aborts in Debug builds, and presumably leads to bad behavior in Release builds.What changes are included in this PR?
Use the output type that Bind resolves for the projected field.
Add a regression test with an
IfThenexpression that maps tocase_when. The test checks the converted schema and query results. It aborts in Debug mode without the corresponding fix.Are these changes tested?
Added a new test which passes after the changes.
Ran other tests in Debug mode with the following command
Are there any user-facing changes?
There are no public API changes apart from the lack of
abort().This PR contains a "Critical Fix"., namely a bug that causes a crash (in Debug mode).
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: