Repository navigation
Conversation
…ecs, compute and JSON Ship trimmed source tarballs of the thirdparty dependencies needed for Parquet, the compression codecs, RE2/utf8proc, JSON and mimalloc in the R package so that offline source builds (e.g. on CRAN) can include those features instead of falling back to a minimal build. * tools/vendor_dependencies.sh (run by `make sync-cpp`) downloads, trims and vendors the tarballs into tools/vendored, and records each one's upstream and trimmed checksums in tools/vendored/checksums.txt. A dependency can provide its own trim script at tools/trim/<name>.sh. * When building the package's copy of the C++ source (tools/cpp), nixlibs.R uses the vendored tarballs that were trimmed from the versions that versions.txt pins, replacing their checksums in versions.txt with the trimmed ones. When offline, it only turns off the features whose dependencies aren't vendored. * The offline CI job (now test-r-offline-vendored) checks that the expected features are available after the build. * Add inst/COPYRIGHTS listing the vendored dependencies' licenses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…eeds The generic trim leaves a 29 MB Boost tarball. tools/trim/boost.sh keeps only the Boost libraries that build_boost() in ThirdpartyToolchain.cmake includes (minus ones the R build doesn't use, e.g. multiprecision) and their dependencies, as resolved by Boost's own CMake, and drops their tests, docs and examples. This brings the vendored Boost down to ~5 MB. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
jonkeane
requested review from
assignUser,
kou,
raulcd and
thisisnic
as code owners
November 11, 2026 01:38
|
|
Member
Author
|
@github-actions crossbow submit test-r-offline-vendored |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The build leaves rewritten checksums in tools/cpp/thirdparty/versions.txt, causing subsequent installs from the same source tree with upstream archives to fail checksum validation.
1 open issue
What changed in this PR
Enables more capable offline R source builds, including Parquet, by shipping trimmed third-party dependencies alongside the bundled Arrow C++ source.
Changes:
- Adds dependency caching, trimming, and upstream/vendored checksum tracking.
- Preserves optional features whose dependencies are available offline.
- Expands offline CI validation and records dependency licensing information.
| File | Description |
|---|---|
r/tools/vendor_dependencies.sh |
Downloads, caches, trims, and records checksums for vendored dependencies. |
r/tools/trim/boost.sh |
Retains the Boost libraries needed by R builds. |
r/tools/test-nixlibs.R |
Tests dependency selection, checksum rewriting, and offline feature handling. |
r/tools/nixlibs.R |
Selects compatible vendored archives and preserves supported offline features. |
r/inst/COPYRIGHTS |
Documents vendored dependency licenses and copyrights. |
r/DESCRIPTION |
References the copyright information. |
r/.Rbuildignore |
Excludes download caches and trimming scripts from source packages. |
r/.gitignore |
Ignores cached upstream archives. |
dev/tasks/tasks.yml |
Configures offline CI to exercise vendored dependencies and expected features. |
dev/release/rat_exclude_files.txt |
Excludes the copyright inventory from license-header checks. |
ci/scripts/r_test.sh |
Verifies expected build capabilities and allocator backends. |
Review effort: Balanced
| # Some of them are required even for a minimal build, so they can't be turned | ||
| # off like the ones above. | ||
| env_var_list <- with_vendored_dependencies(env_var_list, vendored) | ||
| use_vendored_checksums(src_dir, env_var_list, vendored) |
|
Revision: dda15ba Submitted crossbow builds: ursacomputing/crossbow @ actions-7820f0a5a5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Vendor (and trim) C++ dependencies for offline builds that would allow us to build Parquet even when CMake cannot reach the internet. This is an R-package-only change, but in doing so can't trim quite as much (specifically building thrift without boost). The resulting tarball is larger than strictly necessary (~14.2 MB).
Resolves #55478
What changes are included in this PR?
Scripts for vendoring and trimming dependencies, tests
Are these changes tested?
Yes
Are there any user-facing changes?
More full-feature arrow builds
Was AI used for this PR?
In accordance to the AI generation guidelines, please disclose below whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by: