Repository navigation
Conversation
rok
force-pushed
the
gh-55475-merge-button
branch
from
November 10, 2026 21:02
4b8ed1c to
c34e788
Compare
|
|
rok
force-pushed
the
gh-55475-merge-button
branch
5 times, most recently
from
November 10, 2026 22:43
a681b72 to
8af40b8
Compare
rok
force-pushed
the
gh-55475-merge-button
branch
2 times, most recently
from
November 10, 2026 23:14
96ffdb2 to
3a6799e
Compare
rok
marked this pull request as ready for review
November 10, 2026 23:24
rok
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
November 10, 2026 23:24
Write down the squash merge button configuration and count mergers for the release announcement with the GitHub API instead of Signed-off-by trailers. The merge script is still available. Before the merge, a required "Merge check" status check on main only passes when the pull request title is "GH-XXX: [Component] Title" or "MINOR: [Component] Title" and the issue GH-XXX is open and assigned. The required check rejects direct pushes to main, so post-10-bump-versions.sh pushes a branch for a pull request instead and tags the merged commit in a second run. After the merge, a workflow for pushes to main sets the milestone of the issue, closes it, comments which pull request resolved it and removes the "awaiting ..." labels from the pull request.
rok
force-pushed
the
gh-55475-merge-button
branch
from
November 10, 2026 23:41
3a6799e to
65e2f5a
Compare
Comment on lines
+632
to
+633
| and merge it. You can run the script with ``BUMP_PUSH=0`` to review the | ||
| commits before you push them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Rationale for this change
Committers need a personal access token and
dev/merge_arrow_pr.pyto merge. This lets them use the "Squash and merge" button instead, like apache/arrow-rs does. The merge script is kept for now and isn't changed.What changes are included in this PR?
pull_request) blocks the merge unless the title isGH-XXX: [Component] TitleorMINOR: [Component] Titleand the issueGH-XXXis open and assigned.GH-XXXin the title is the only link to the issue that is needed.pushtomain) sets the milestone of the issue (the milestone of the pull request if it has one, otherwise the same default as the merge script), closes it, comments "Issue resolved by pull request XXX" and removes theawaiting ...labels from the pull request..asf.yaml, matches the current settings).Signed-off-by:trailers.post-10-bump-versions.shcan't push tomaindirectly anymore because of the required check: it pushes a branch for aMINOR: [Release] ...pull request, and the.devtag is created by a second run after the pull request is merged.Only pull requests to
mainare covered.Things to discuss
.devtag.Authored-by:/Signed-off-by:trailers for button merges (GitHub addsCo-authored-by:), and the description isn't cleaned unless the committer does it in the merge dialog.mainwould be rejected by the title rule alone. The check doesn't run again when the issue changes, so re-run it or edit the pull request after e.g. assigning the issue.pull_request: the check runs the workflow of the pull request, so a pull request can change the check itself. It needs approval to run for first-time contributors.Are these changes tested?
Only locally: the JavaScript logic with a fake GitHub client and the mergers script against the last 120 commits. "Merge check" runs on this pull request. The "Dev PR merged" workflow and the required check can only run once this is on
main. The changed push and tag steps ofpost-10-bump-versions.shhave not been run.Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: