Skip to content

GH-35721: [Python] Recognize pandas arrays in the array() constructor for the from_pandas argument #55477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jay23606 wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −1
Open

GH-35721: [Python] Recognize pandas arrays in the array() constructor for the from_pandas argument #55477

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion python/pyarrow/array.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5384,7 +5384,8 @@ cdef object get_values(object obj, bint* is_pandas_object):
is_pandas_object[0] = False
else:
result = pandas_api.get_values(pandas_api.series(obj, copy=False))
is_pandas_object[0] = False
# pandas ExtensionArrays (e.g. pd.array(...)) get pandas semantics
is_pandas_object[0] = pandas_api.is_extension_array_dtype(obj)

return result

Expand Down
11 changes: 11 additions & 0 deletions python/pyarrow/tests/test_array.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2631,6 +2631,17 @@ def test_pandas_null_sentinels_index():
assert result.equals(expected)


@pytest.mark.pandas
def test_pandas_null_sentinels_extension_array():
# GH-35721 - pandas ExtensionArrays should use "from_pandas" semantics
import pandas as pd
arr = pd.array([1.2, np.nan], dtype=float)
result = pa.array(arr)
expected = pa.array([1.2, np.nan], from_pandas=True)
assert result.equals(expected)
assert result.null_count == 1


@pytest.mark.numpy
def test_array_roundtrip_from_numpy_datetimeD():
arr = np.array([None, datetime.date(2017, 4, 4)], dtype='datetime64[D]')
Expand Down
Loading