Repository navigation
GH-51816: [GLib] Add filesystem GType registration mechanism - #55464
Open
alytantawyy wants to merge 2 commits into
Open
alytantawyy wants to merge 2 commits into
alytantawyy wants to merge 2 commits into
Conversation
alytantawyy
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
November 10, 2026 02:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Arrow GLib currently selects filesystem wrappers from a fixed list. A registry lets separately packaged filesystem bindings provide their own GLib wrapper types, preparing for the S3 bindings split in #51608.
Closes #51816.
What changes are included in this PR?
GTyperegistration, with validation and duplicate-name errors.GArrowFileSystemconstructible so an unregistered C++ filesystem can use the generic wrapper.Are these changes tested?
Verified locally on macOS arm64:
Are there any user-facing changes?
Adds
garrow_file_system_register_type()and allows unregistered C++ filesystem implementations to be wrapped as a genericGArrowFileSystem. Existing built-in wrapper mappings remain available. Moving S3 bindings into a separate library is outside this PR's scope.Was AI used for this PR?
Codex generated the implementation, tests, and this description, and performed an AI review and local build, test, and lint verification.
PR code and description written by:
Reviewed before submission by: