Repository navigation
GH-55429: [C++] std::invocable in codegen_internal.h fails to compile with CRAN's macOS 11.3 SDK - #55457
Merged
Conversation
Member
Author
|
@github-actions crossbow submit test-r-macos-as-cran |
|
|
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the macOS SDK compatibility changes.
No open issues 🎉
What changed in this PR
This PR addresses C++ build compatibility with CRAN’s macOS 11.3 SDK by replacing unavailable standard-library features with older equivalents.
Changes:
- Replace
std::invocableconstraints withstd::is_invocable_vin compute kernel generation. - Replace
std::in_rangechecks with an integer-capacity trait and add compile-time assertions for representative type pairs.
| File | Description |
|---|---|
cpp/src/parquet/column_reader.cc |
Use numeric limits and signedness to check integer capacity without std::in_range. |
cpp/src/arrow/compute/kernels/codegen_internal.h |
Use std::is_invocable_v and remove the <concepts> include. |
Review effort: Balanced
|
Revision: cc05f47 Submitted crossbow builds: ursacomputing/crossbow @ actions-fd168d079e
|
pitrou
reviewed
Nov 9, 2026
pitrou
approved these changes
Nov 9, 2026
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
Member
Author
|
CI failures looked unrelated but it's all running again since I accept the changes suggested |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
macOS on CRAN is old and doesn't have all the C++20 stuff in it - evidenced by failing CI
What changes are included in this PR?
Refactor code which requires newer stuff that the CRAN stuff doesn't have
Are these changes tested?
Will run CI
Are there any user-facing changes?
Nah
Was AI used for this PR?
Yeah, all generated but I checked it with an adversarial review and will run CI to make sure it actually works
PR code and description written by:
Reviewed before submission by: