Repository navigation
GH-55429: [C++] Avoid unavailable libc++ utilities in CRAN builds - #55438
Closed
JonSnow1807 wants to merge 1 commit into
Closed
JonSnow1807 wants to merge 1 commit into
JonSnow1807 wants to merge 1 commit into
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #55429.
Closes #55430.
Rationale for this change
The CRAN macOS build uses the macOS 11.3 SDK, whose libc++ lacks std::invocable and std::in_range.
The std::invocable failure occurs first and masks the std::in_range failure, so both need to be addressed for this build configuration.
What changes are included in this PR?
Replace std::invocable with std::is_invocable_v in the two transform constraints in codegen_internal.h, and remove the unused
<concepts>include.Replace the endpoint-based std::in_range checks in Parquet’s can_hold_v with a comparison of numeric_limits::digits and signedness. The predicate continues to determine whether the destination integer type can represent the source type’s complete range.
Are these changes tested?
A Linux GCC 13 source build succeeds with the patch.
The targeted suites pass:
The integer-range predicate was also checked against the previous expression for 64 signed and unsigned integer-type pairs. Formatting passes with the repository’s pinned clang-format 18.1.8.
The macOS 11.3 SDK was unavailable in the validation environment, so the exact test-r-macos-as-cran build still needs CI verification.
Are there any user-facing changes?
This addresses compilation failures with the older libc++ used by the CRAN build. No public API or intended runtime behavior changes.
Was AI used for this PR?
AI tools assisted with implementation, review, and validation. I reviewed the code, tests, and description before submission.
PR code and description written by:
Reviewed before submission by: