Repository navigation
GH-55356: [C++] Compare mtime at second precision in GetFileInfoSelector test - #55433
Merged
Merged
Conversation
|
|
tadeja
changed the title
GetFileInfoSelector test
tadeja
changed the title
GetFileInfoSelector tests precision in GetFileInfoSelector test
tadeja
changed the title
s precision in GetFileInfoSelector testGetFileInfoSelector test
rok
reviewed
Nov 7, 2026
Co-authored-by: Rok Mihevc <rok@mihevc.org>
rok
approved these changes
Nov 7, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the test-only change accommodating differing S3 timestamp precision.
No open issues 🎉
What changed in this PR
Updates the shared C++ filesystem selector test to accommodate differing S3 timestamp precision with AWS SDK 1.11.900 and newer, addressing GH-55356 without changing production behavior.
Changes:
- Floors the listing timestamp to seconds when the single-file timestamp has second precision and the listing timestamp has millisecond precision.
| File | Description |
|---|---|
cpp/src/arrow/filesystem/test_util.cc |
Conditionally normalizes timestamp precision before comparing selector and single-file results. |
Review effort: Balanced
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
#55356 -
TestS3FSGeneric.GetFileInfoSelectorfails with AWS SDK 1.11.900 and newer.See aws/aws-sdk-cpp#3934
ListObjectsV2results keep milliseconds whileHeadObject'sLast-Modifiedheader only has seconds.What changes are included in this PR?
Floor the listing
mtimefrom milliseconds to seconds inGetFileInfoSelectortest when the single filemtimehas only seconds.Are these changes tested?
Locally on macOS arm64 with AWS SDK 1.11.900 and MinIO.
Are there any user-facing changes?
No.
Was AI used for this PR?
PR code and description written by:
Reviewed before submission by: