Skip to content

GH-55385: [C++][Parquet] Remove unused last_value_in_previous_page_ from DeltaByteArrayDecoderImpl #55386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamreeve merged 1 commit into from
Nov 4, 2026
Merged

GH-55385: [C++][Parquet] Remove unused last_value_in_previous_page_ from DeltaByteArrayDecoderImpl #55386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions cpp/src/parquet/decoder.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2050,7 +2050,6 @@ class DeltaByteArrayDecoderImpl : public TypedDecoderImpl<DType> {
pool_(pool),
prefix_len_decoder_(nullptr, pool),
suffix_decoder_(nullptr, pool),
last_value_in_previous_page_(""),
buffered_prefix_length_(AllocateBuffer(pool, 0)),
buffered_data_(AllocateBuffer(pool, 0)) {}

Expand Down Expand Up @@ -2081,8 +2080,6 @@ class DeltaByteArrayDecoderImpl : public TypedDecoderImpl<DType> {
// at this time, the decoder_ will be at the start of the encoded suffix data.
suffix_decoder_.SetData(num_values, data + suffix_begins, bytes_left);

// TODO: read corrupted files written with bug(PARQUET-246). last_value_ should be set
// to last_value_in_previous_page_ when decoding a new page(except the first page)
last_value_.clear();
}

Expand Down Expand Up @@ -2309,10 +2306,6 @@ class DeltaByteArrayDecoderImpl : public TypedDecoderImpl<DType> {
num_valid_values_ -= max_values;
last_value_ = std::string{prefix};

if (num_valid_values_ == 0) {
last_value_in_previous_page_ = last_value_;
}

return max_values;
}

Expand Down Expand Up @@ -2363,8 +2356,6 @@ class DeltaByteArrayDecoderImpl : public TypedDecoderImpl<DType> {
DeltaBitPackDecoder<Int32Type> prefix_len_decoder_;
DeltaLengthByteArrayDecoder suffix_decoder_;
std::string last_value_;
// string buffer for last value in previous page
std::string last_value_in_previous_page_;
int num_valid_values_{0};
uint32_t prefix_len_offset_{0};
std::shared_ptr<ResizableBuffer> buffered_prefix_length_;
Expand Down
Loading