Conversation
|
|
|
Thanks for opening a pull request! This pull request has been automatically closed because you currently have 5 open pull requests, which is more than the limit of 3. Due to the increase in pull requests opened by AI bots, and in order to keep the review queue manageable, Apache Arrow limits contributors without write access to at most 3 concurrently open pull requests. This helps make sure each pull request gets the attention it needs and that work in progress does not go stale. Once one of your other open pull requests has been merged or closed, you are welcome to reopen this one. See also: |
|
Once #50513 is merged, we can verify that the updated type list works correctly. |
|
@Reranko05 , as I expected, this is breaking a lot of existing tests for functionality that doesn't accept Float16 currently. The easy way out is to avoid running those tests on Float16, but it would be nicer of course to progressively have all the tested functionality accept Float16. |
|
@pitrou Okay, so should I update the affected tests to avoid float16 for now? |
|
Yes, probably. Perhaps using a test-only function that would return floating-point types without Float16. |
|
@pitrou |
Rationale
FloatingPointTypes()currently contains onlyfloat32()andfloat64(), sofloat16()is also omitted fromNumericTypes()andPrimitiveTypes().This was noted as a follow-up during the review of #50513.
Changes
float16()toFloatingPointTypes().NumericTypes()andPrimitiveTypes()automatically includefloat16()through their existing composition fromFloatingPointTypes().Testing
arrow-type-testpasses.GitHub Issue: #51311
float16part ofFloatingPointTypes()#51311