Skip to content

[CI] Remove pull_request_target event workflows #55392

Open
2 of 3 issues completed
Open

Description

@raulcd

Describe the enhancement requested

GitHub is going to block the pull_request_target event from the 2nd of December:

We should remove / migrate the current workflows that make use of pull_request_target. Currently used on our:

  • .github/workflows/dev_pr.yml --> Linking issues, labeling PR and checking PR title
  • .github/workflows/pr_bot.yml --> Adds review labels
  • .github/workflows/pr_limit.yml --> Limits numbers of PRs opened for non committers/collaborators.

Component(s)

Continuous Integration

Activity

  1. raulcd commented on Nov 4, 2026

    @raulcd
    MemberAuthor

    For .github/workflows/pr_limit.yml we can migrate to the .asf.yaml functionality (collaborators won't be covered here).
    For .github/workflows/pr_bot.yml we should just remove the whole awaiting review, awaiting change, etc as it creates noise and has never really worked.
    For the .github/workflows/dev_pr.yml I have to explore a little further to come up with ideas.

    @kou @pitrou @thisisnic thoughts? I am happy to start working on the first two. I might split in sub-issues one per workflow.

  2. raulcd commented on Nov 4, 2026

    @raulcd
    MemberAuthor

    It seems datafusion is coming up with a two workflows approach for the labelers:

    As @andygrove points here:

    Move to the two-workflow pattern that apache/datafusion#26683 uses:

    1. A pull_request workflow with no write access records the PR number (and the changed paths, if needed) and uploads it as an artifact.
    2. A workflow_run workflow, triggered when the first one completes, runs in the base repository context with pull-requests: write, reads the artifact, and applies the labels from .github/workflows/dev_pr/labeler.yml. It treats the artifact as untrusted data and never checks out or runs PR code.
  3. kou commented on Nov 5, 2026

    @kou
    Member

    For .github/workflows/pr_limit.yml we can migrate to the .asf.yaml functionality (collaborators won't be covered here).

    +1

    For .github/workflows/pr_bot.yml we should just remove the whole awaiting review, awaiting change, etc as it creates noise and has never really worked.

    +1

    For the .github/workflows/dev_pr.yml I have to explore a little further to come up with ideas.

    How about using only pull_request instead of pull_request + workflow_run? We will lost some current functions but it will not introduce complexities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions