You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[C++][Release] verify-rc-source-windows fails with latest simdjson (5.0.1) from conda #51690
introduced by #46963 is the cause of this. It's already included in our past releases. We can fix it in the next release.
BTW, I feel that the approach used by #46963 is not a good approach because it always defines __*__ globally by add_definitions() (other SIMD related flags cares about ARROW_SIMD_LEVEL) and we should not define __*__ macros as much as possible (I think that simdjson/simdjson#2864 (comment) is correct).
One other related point: simdjson 5.0.2 also includes a fix for an empty-input issue in truncated_bytes() (simdjson#2889) that we're currently working around in #51038. So once we fix the __*__ definitions on our side and can bump simdjson, we'll also pick up that fix.
Activity
raulcd commentedon Oct 2, 2026
@pitrou @kou @Reranko05 is this a blocker? Should I just pin
simdjson < 5or use bundled on the verification job for Windows?raulcd commentedon Oct 2, 2026
Marking this potentially as 26.0.0 until feedback even though I think it's not a blocker.
kou commentedon Oct 2, 2026
I think that this is not a blocker.
It seems that
arrow/cpp/cmake_modules/SetupCxxFlags.cmake
Line 56 in e85e181
BTW, I feel that the approach used by #46963 is not a good approach because it always defines
__*__globally byadd_definitions()(other SIMD related flags cares aboutARROW_SIMD_LEVEL) and we should not define__*__macros as much as possible (I think that simdjson/simdjson#2864 (comment) is correct).Reranko05 commentedon Oct 3, 2026
@raulcd I don't think this is a blocker either.
Reranko05 commentedon Oct 6, 2026
One other related point: simdjson 5.0.2 also includes a fix for an empty-input issue in
truncated_bytes()(simdjson#2889) that we're currently working around in #51038. So once we fix the__*__definitions on our side and can bump simdjson, we'll also pick up that fix.kou commentedon Oct 16, 2026
If xtensor-stack/xsimd#1430 is merged, we can use
XSIMD_WITH_SSE4_2instead of__SSE4_1__and__SSE4_2__.Allow setting XSIMD_WITH_SSE3, SSSE3, SSE4_1 and SSE4_2 manually with…