Skip to content

refactor(schema): use REE field name constants - #11064

Open
akashchamp wants to merge 1 commit into
apache:mainfrom
akashchamp:issue-11035-use-ree-field-constants
Open

refactor(schema): use REE field name constants#11064
akashchamp wants to merge 1 commit into
apache:mainfrom
akashchamp:issue-11035-use-ree-field-constants

Conversation

@akashchamp

Copy link
Copy Markdown

Closes #11035

Assisted-by: Codex

Summary

Use the existing REE default field-name constants wherever arrow-schema constructs fields with the default run_ends and values names. Intentional custom named_values parsing and display cases remain unchanged.

Testing

  • cargo fmt --all -- --check
  • cargo test -p arrow-schema — 108 unit tests and 41 doctests passed.
  • cargo test -p arrow-schema --all-features — 179 unit tests and 43 doctests passed.
  • cargo clippy -p arrow-schema --all-targets --all-features -- -D warnings
  • Manually exercised display/parse round trips for both the default REE schema and a custom named_values schema; each parsed back to the original data type.

User-facing changes

None.

AI assistance was used to identify and apply the mechanical substitutions. I reviewed every changed construction and confirmed custom-name cases remain explicit.

Replace default run-end encoded field-name literals with the shared constants.
@github-actions github-actions Bot added arrow Changes to the arrow crate arrow-schema labels Sep 12, 2026

@Rich-T-kid Rich-T-kid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems straightforward, thank you @akashchamp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arrow Changes to the arrow crate arrow-schema

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wire REE field name constants to more usages in arrow-schema

2 participants