test(parquet): move async reader tests to integration target - #11063
Open
akashchamp wants to merge 1 commit into
Open
test(parquet): move async reader tests to integration target#11063akashchamp wants to merge 1 commit into
akashchamp wants to merge 1 commit into
Conversation
Keep private-API coverage in the source module and run public async reader tests through the Parquet integration target.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The async reader implementation module contains a large group of tests that exercise only public APIs. Moving those tests to the existing Parquet integration target keeps production code and tests easier to navigate while preserving the tests that intentionally exercise crate-private helpers.
What changes are included in this PR?
parquet/tests/arrow_reader/async_reader.rs.asyncfeature.Are these changes tested?
cargo test -p parquet --features async: 1,395 unit tests, 142 integration tests (1 ignored), and 81 doctests (7 ignored) passed.cargo clippy -p parquet --all-targets --features async -- -D warnings, repository formatting, and the pinned typos check passed.async_readertests from the integration binary and directly ranasync_reader::test_async_readersuccessfully.Are there any user-facing changes?
No. This reorganizes tests only and does not change production behavior or public APIs.
AI assistance
Assisted-by: Codex
AI assistance was used to prepare the initial test extraction. I reviewed every moved test, retained the crate-private coverage in the source module, and manually validated the extracted integration target.