fix: preserve zero-width FixedSizeBinary length when filtering - #11042
Merged
Jefffrey merged 2 commits intoSep 15, 2026
Merged
Conversation
Rich-T-kid
changed the title
Jefffrey
reviewed
Sep 15, 2026
| FixedSizeBinaryArray::try_new_with_len( | ||
| array.value_length(), | ||
| buffer.into(), | ||
| None, |
Contributor
There was a problem hiding this comment.
what about using try_new_with_len unconditionally without needing to branch
Jefffrey
approved these changes
Sep 15, 2026
Contributor
|
thanks @Rich-T-kid |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
edge case that currently isnt covered
What changes are included in this PR?
checks for if array is empty and has no nulls, if so set the len outright
Are these changes tested?
yes
Are there any user-facing changes?
no