Optimize batched bit unpacking - #11027
Draft
sdf-jkl wants to merge 1 commit into
Draft
Conversation
Member
Author
|
run benchmark arrow_reader alp arrow_reader_clickbench |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark arrow_readerBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark alpBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench alp File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark arrow_reader_clickbenchBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench arrow_reader_clickbench File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark alpCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark arrow_reader_clickbenchCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing unpack_batch (284f700) to 8c265f8 (merge-base) diff Run configurationrun benchmark arrow_readerCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
BitReader::get_batchcurrently performs runtime bit-width dispatch for every complete native unpack block. For larger batches, this repeatedly enters the same jump table even though the bit width is constant for the entire call.What changes are included in this PR?
FromBitpacked::unpack_batchesfallback and optimized implementations for the built-in integer, signed integer, and boolean types.This is intentionally limited to unpacking. The related packing work remains separate.
Are these changes tested?
Yes. Existing
get_batchtests exhaustively cover supported bit widths, signed and unsigned integer types, booleans, zero width, and batch sizes including 128 and 129 values that exercise the multi-block path.Validated locally with:
cargo test -p parquet --features experimental --lib(1,374 passed)cargo clippy -p parquet --all-targets --features experimental -- -D warningscargo fmtcheckcargo fmtcheckBenchmark results will be added before this draft is marked ready. Earlier exploratory results were collected from a mixed development branch and are deliberately not attributed to this smaller patch.
Are there any user-facing changes?
No behavior changes are intended.
FromBitpackedgains a provided method, so existing implementations remain source-compatible.