[Parquet] Vectorise Pack Bits within BitWriter - #10432
Open
sdf-jkl wants to merge 18 commits into
Open
Conversation
Member
Author
|
run benchmark arrow_writer |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Member
Author
|
run benchmark arrow_writer |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: CPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Member
Author
|
@Jefffrey @etseidl could you please take a look at this? I ran the same bench on my machine and don't get the regressions from the previous bot run. ( My last run if from a different main. My machine is x86) |
Contributor
|
lets split the bench changes to a separate PR so the bot can compare them from main |
Member
Author
|
run benchmark bit_packing |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing put_batch (3fef6c0) to 901e69f (merge-base) diff Run configurationrun benchmark bit_packingBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench bit_packing File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing put_batch (3fef6c0) to 901e69f (merge-base) diff Run configurationrun benchmark bit_packingCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
Member
Author
Contributor
|
i do still have this in my review backlog, hopefully will get to it eventually 😅 |
Member
Author
|
@alamb this is ALP related 👀 |
# Conflicts: # parquet/src/encodings/rle.rs
Contributor
|
I plan to review this -- I have been out at VLDB this week so my review backlog is quite large now |
Member
Author
Member
Author
|
run benchmark bit_packing alp |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing put_batch (3f8e0de) to cb682a2 (merge-base) diff Run configurationrun benchmark bit_packingBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench bit_packing File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing put_batch (3f8e0de) to cb682a2 (merge-base) diff Run configurationrun benchmark alpBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench alp File an issue against this benchmark runner |
|
Benchmark for this request failed before finishing (Kubernetes reason: Benchmarks requested: Runner log (last 40 lines)Kubernetes messageFile an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing put_batch (3f8e0de) to cb682a2 (merge-base) diff Run configurationrun benchmark bit_packingCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
sdf-jkl
marked this pull request as draft
September 7, 2026 15:57
Member
Author
|
Want to test some things before we proceed |
Member
Author
|
run benchmark bit_packing alp |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing put_batch (77cf89a) to b06b9c1 (merge-base) diff Run configurationrun benchmark bit_packingBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench bit_packing File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark running (GKE) | trigger CPU Details (lscpu)Comparing put_batch (77cf89a) to b06b9c1 (merge-base) diff Run configurationrun benchmark alpBENCH_COMMAND=cargo bench --features=arrow,async,test_common,experimental,object_store --bench alp File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing put_batch (77cf89a) to b06b9c1 (merge-base) diff Run configurationrun benchmark bit_packingCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
|
🤖 Arrow criterion benchmark completed (GKE) | trigger Instance: Comparing put_batch (77cf89a) to b06b9c1 (merge-base) diff Run configurationrun benchmark alpCPU Details (lscpu)Details
Resource Usagebase (merge-base)
branch
File an issue against this benchmark runner |
sdf-jkl
marked this pull request as ready for review
September 9, 2026 21:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Perf 🚀
What changes are included in this PR?
FromBitpackedtoBitPackingto store the Packing APIspack_batchmatchingunpack_batchkernelsAre these changes tested?
Yes!
Are there any user-facing changes?
No