Repository navigation
GH-1454: Declare ID as nullable in the local files Substrait test plan - #1456
Merged
Merged
Conversation
…st plan local_files_users.json declared ID as required, but the Parquet file the test reads has an optional id column and the test expects a nullable ID. Arrow C++ main now keeps the input nullability of projected fields (apache/arrow#51691), so the scan returned ID as not null and testRunQueryLocalFiles failed in the nightly build.
lidavidm
approved these changes
Nov 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
dataset/src/test/resources/substrait/local_files_users.jsondeclaredIDasNULLABILITY_REQUIRED. The Parquet file thattestRunQueryLocalFilesreads has an optionalidcolumn, and the test expects a nullableID. Since apache/arrow#51691, Arrow C++ keeps the input nullability of directly projected fields, so a build against Arrow C++mainreturnsIDasnot nulland the test fails. That is why the nightly Binaries job fails.This declares
IDasNULLABILITY_NULLABLE, which matches the file.named_table_users.jsonalso declaresIDas required, but the named-table tests read a table supplied from Java with a nullableID, and they pass against both versions, so it's unchanged.I ran
TestAceroSubstraitConsumerwith thejni-macos-aarch_64libraries from the RC workflow, which are built from Arrow C++main. Before this changetestRunQueryLocalFilesfails with the nightly's error; after it, all 11 tests pass. Arrow C++ 26.0.1 projects every field as nullable, so the result there doesn't change.Closes #1454.