[AMORO-4384]add jdk version check and add more add-opens - #4385
Conversation
|
Could we use |
thanks for you advice. nice catch. i have fixed it. PTAL |
You are welcome. The fix looks fine. @zhoujinsong please validate |
zhoujinsong
left a comment
There was a problem hiding this comment.
LGTM.
BTW, I noticed the optimizer.sh script have some similar logic about changing the JVM variables depend on the JDK version.
We may polish the implementation here in another PR.
* fix# 4384 add jdk version check and add more add-opens * fix * fix according to the comment
Why are the changes needed?
Close #4384 .
Brief change log
How was this patch tested?
Add some test cases that check the changes thoroughly including negative and positive cases if possible
Add screenshots for manual tests if appropriate
Run test locally before making a pull request
Documentation