Repository navigation
Conversation
String comparison with mixed-case values returned incorrect results. 'D' < 'a' returned false, but D (U+0044) has a lower Unicode code point than a (U+0061) so the expected result is true. Adds regression tests to expr.sql covering single character, doubled character, combined query, and concatenated string comparison cases. Fixes apache#2604
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2604.
String comparisons between uppercase and lowercase characters return incorrect results in AGE.
'D' < 'a'returnsfalsebut D (U+0044) has a lower Unicode code point than a (U+0061), so the expected result istrue.Regression tests added
Added tests to
regress/sql/expr.sqlandregress/expected/expr.outcovering:'D' < 'a'→ expectedtrue'DD' < 'a'→ expectedtrue'DD' >= 'a'→ expectedfalseUNWINDto verifyNOT ((value + value) >= 'a')returns correct per-row resultsExpected output
The
.outfile records the correct expected values based on Unicode code point ordering, so the regression test will fail until the underlying comparison bug is fixed.