Skip to content

Add missing ASF license header to DefaultRedeliveryPolicy.cs - #55

Merged
Havret merged 1 commit into
apache:mainfrom
lobtx:NO-JIRA-asf-header-DefaultRedeliveryPolicy
Nov 10, 2026
Merged

Havret merged 1 commit into
apache:mainfrom
lobtx:NO-JIRA-asf-header-DefaultRedeliveryPolicy

Conversation

@lobtx

@lobtx lobtx commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

src/DefaultRedeliveryPolicy.cs (added with AMQNET-850) has no ASF license header. I noticed it while
checking the 2.2.0 and 2.3.0 source releases. This adds the same header as the other source files.

Comment only, no code change; dotnet build nms-openwire.sln -c Release passes (SDK 8.0).

Two related points from the release checks, left out of this PR on purpose, happy to open separate PRs if you think they should be handled:

  • src/nms-openwire.csproj, test/nms-openwire-test.csproj, Directory.Build.props and test/TestDbConfig.xml have no license header either (common for .NET project files, so I'm not sure it's wanted).
  • the source release ships compiled binaries, ext_bin/Apache.NMS.Test.dll and .pdb, while ASF source releases are not supposed to contain any compiled code.

AI tool used: Claude Code (Claude Opus 5.5), reviewed and checked by me.

Claude Code on behalf of lobtx

🤖 Generated with Claude Code

DefaultRedeliveryPolicy.cs was added without the ASF license header,
which shows up when checking the source release (since 2.2.0).

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the ASF license-header addition to DefaultRedeliveryPolicy.cs.

No open issues 🎉

What changed in this PR

Adds the missing ASF license header to DefaultRedeliveryPolicy.cs, aligning it with the other source files.

Changes:

  • Adds the standard Apache License 2.0 header; executable code and runtime behavior are unchanged.
File Description
src/​DefaultRedeliveryPolicy.cs Adds the ASF license header above the existing code.

Review effort: Balanced

@Havret
Havret merged commit c8bc67f into apache:main Nov 10, 2026
1 check passed
@Havret

Havret commented Nov 10, 2026

Copy link
Copy Markdown
Contributor

Thanks @lobtx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants