Fixed some minor bugs in FileOperations and CachableBlockFile - #6493
Merged
Conversation
Removed the wait loop in FileOperations.openFile as the call to future.get performs a non-blocking wait. Added checks in CachableBuilder to help users use the object correctly. Calls to input() and fsPath() will open the same file twice and create two InputStreams.
ddanielr
approved these changes
Jul 28, 2026
ddanielr
left a comment
ddanielr
left a comment
Contributor
There was a problem hiding this comment.
The conditional checking looks correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the wait loop in FileOperations.openFile as the call to future.get performs a non-blocking wait.
Added checks in CachableBuilder to help users use the object correctly. Calls to input() and fsPath() will open the same file twice and create two InputStreams.