Remove compaction related TODOs - #6491
Open
Amemeda wants to merge 2 commits into
Open
Conversation
DomGarguilo
requested changes
Jul 28, 2026
Amemeda
marked this pull request as ready for review
July 28, 2026 19:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExternalCompaction4_IT, the test is already using a valid compaction server config. Changed cs4 to cs1 to be less random.ExternalCompactionMetricsIT.testMetrics. TODO was misleading, the code was already not checking the queue, but the ECOMP metadata. Reworked this check to ensure all compaction jobs have completed by waiting for the ECOMP metadata to be cleared from Accumulo metadata.This pr resolves 2 TODOs from #2699