85893 mcp log search by - #107
Open
scaree wants to merge 16 commits into
Open
Conversation
…xed datetime sort
…ertion, changelog placement
…d of a dedicated permission set
Moves the integration onto the per-server container layout: the controller is aliased to mcp.server.<server_name>.controller, both request handlers take that server's registry, and the tool-list page size is read from the server config now that the mcp.pagination_limit parameter is gone. File-based discovery is replaced by the mcp.tool tag plus a registry pattern, so the bundle prepends its own tool namespace instead of a vendor scan dir. The controller builds its middleware through the McpBundle MiddlewareFactory, because SDK 0.8 applies ProtocolVersionMiddleware to handshake-era traffic itself and a hand-built list carrying it rejects every 2026-07-28 request. allowed_hosts stays on this side: the McpBundle option is validated as an array at compile time, which an env-csv value cannot satisfy. Also carries the MCP review findings: tool errors answer with isError set instead of a successful result holding an error key, the rate limit is charged per JSON-RPC message so a batch cannot spend one token on 100 tool calls, the log tools warn about a truncated result only when rows were really cut off, and an empty tool_permissions map fails at compile time like an empty allowed_hosts.
…by_id # Conflicts: # CHANGELOG.md
Ordered imports in McpLogFinder, the stray blank lines the MCP tool imports and the log search response trait picked up, and the chained ToolResultFormatter call split onto its own line.
…lias ContainerBuilder::getParameter() returns the whole parameter union, so psalm rejected passing it to sprintf. The guard mirrors the one the pass used for the session cache pool and fails at compile time on a misconfigured parameter.
The pass no longer owns the session cache definition and aliases mcp.server.<server_name>.controller instead of mcp.server.controller, so the test drops the removed SESSION_CACHE_POOL_PARAM assertions and covers the server name guard instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.