Repository navigation
chore(release): simplify workflow — bump-level dispatch, drop testpypi/preflight/smoke - #55
Merged
Merged
Conversation
…i/preflight/smoke - Replace `version` + `target` inputs with a `bump` choice (patch/minor/major, default patch) and an optional `version` override. A new `resolve` job computes the next version from framework/core/pyproject.toml and shares it with downstream jobs. - Remove the preflight job (version validation now happens in `resolve`; the pr.yml gating was the last consumer of `actions: read`). - Remove the post-release smoke job and the testpypi-only smoke-testpypi job. - Drop testpypi entirely: the target input, its environment, the conditional publish-npm gate, and the repository-url conditional on pypa-publish. - Stop running pr.yml on push to main (it only triggered so the old preflight could read its conclusion). - Harden npm publish: verify the tarball's package.json names @simple-module-py/<matrix.package> before publishing, and prefix the path with `./` so npm doesn't parse it as a GitHub user/repo shorthand. - Update docs/release.md to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version+targetinputs with abumpchoice (patch/minor/major, defaultpatch) plus an optionalversionoverride. A newresolvejob computes the next version fromframework/core/pyproject.tomland shares it with every downstream job.repository-urlconditional).pr.ymlon pushes tomain— the preflight gate was its only consumer, so push runs were pure waste.publish-npm: verify the tarball'spackage.jsonis scoped to@simple-module-py/<matrix.package>before publishing, and prefix the path with./so npm doesn't parsedist-npm/simple-module-py-ui-0.0.1.tgzas a GitHubuser/reposhorthand (root cause of the recent publish failure).Why
The TestPyPI rehearsal, preflight gating, and post-release smoke were all optional safety nets that rarely caught anything and made the dispatch UI noisy. The bump-level dispatch matches how I actually pick versions; keeping an explicit override preserves the escape hatch for prereleases. The npm guard fixes a real failure from the last release attempt.
Test plan
bump: patch, noversion) once merged and verifyresolvepicks the expected next versionversion(e.g. prerelease tag) and confirm the override pathpublish-npmmatrix no longer triggers thessh://git@github.com/dist-npm/...error