feat(dashboard): platform-only stats behind dashboard.view (#374) [stack 3/11] - #387
Merged
Merged
Conversation
Deploying simple-module-python with
|
| Latest commit: |
103b976
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a2556886.simple-module-python.pages.dev |
| Branch Preview URL: | https://tenancy-03-dashboard.simple-module-python.pages.dev |
…ls (review of #374) Gating the stats on dashboard.view took them away from every non-admin on every install. With multi_tenant off the install is the only tenant, so the module now maps dashboard.view onto the platform user role at startup. With multi_tenant on it stays unmapped: every tenant member holds user. Claude-Session: https://claude.ai/code/session_01F8RiTBUJQnZmSq56qReZeV
antosubash
added this pull request to stack #397
October 1, 2026 16:14
antosubash
marked this pull request as ready for review
October 1, 2026 16:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #374. Stack 3/11 of the tenancy-adoption series (base: #386).
What
/api/dashboard/statshad no permission guard, so any tenant member could see platform-wide user counts and health. Dashboard stats are now platform-only:dashboard.viewpermission. Admin holds it through*, and no tenant role is mapped to it.RequiresPermission("dashboard.view")on the stats API./dashboard/is still everyone's post-login landing page. Viewers without the permission getcan_view_stats=falseand a welcome card (Home.tsx), and no stats props are sent to them.Useris not tenant-scoped, and the cache never opens the API to anyone without the permission (tested).Non-admin platform users (the plain
userrole) no longer see the stats until an admin grantsdashboard.viewin the role editor.Tests
test_dashboard_permission.py.make test-py: 3342 passed.make lintis clean.https://claude.ai/code/session_01F8RiTBUJQnZmSq56qReZeV